Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Fix images for the docs separation post #32257

Merged
merged 12 commits into from
Apr 14, 2022

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Apr 12, 2022

@danilo-leal danilo-leal added docs Improvements or additions to the documentation blog labels Apr 12, 2022
@mui-bot
Copy link

mui-bot commented Apr 12, 2022

No bundle size changes

Generated by 🚫 dangerJS against 00dd0dd

@mbrookes
Copy link
Member

Could we take advantage of this PR to clarify what the difference is in the search result images?

Instead of: "Here is a comparison of before and after when searching for the "pagination" feature:"

"Previously a search for pagination returned results for the Material UI pagination component, followed by those for the data grid:

[first image]

Now when viewing the MUI X section, only results related to the data grid pagination feature are returned:

[second image]"

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 13, 2022

I'm on my Twitter feed, looking at our latest tweet: https://twitter.com/MUI_hq/status/1513971476038311939, looking into writing something to congratulate the work of the team publicly, but it got me thinking before doing such. What do you think about these two potential opportunities?

  1. we remove the default social image for all blog posts (i.e. we have something personalized or nothing). I feel like the core content of the tweet would work better without the default image (compared to the current tweet rendering):

Screenshot 2022-04-13 at 11 18 33

  1. We use the first image as a social card, it would work better than 1. and current:

Screenshot 2022-04-13 at 11 22 19

(same reasoning for https://mui.com/blog/lab-date-pickers-to-mui-x/)

@danilo-leal
Copy link
Contributor Author

We use the first image as a social card

I think that would work perfectly. If I'm not mistaken, the markdown files already support that, don't they?

@samuelsycamore
Copy link
Member

@oliviertassinari I think option 2 is preferable there—it's always better to have any image rather than none at all, so you'll have a better chance of catching eyes while scrolling the feed. Eventually I would like for us to integrate custom OG cards (#32036) for each page, ideally automated.

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 13, 2022

If I'm not mistaken, the markdown files already support that, don't they?

@danilo-leal Correct, it needs a card.png image and

you'll have a better chance of catching eyes while scrolling the feed

@samuelsycamore Agree, but to explain my reasoning, I need to add two variables: Y: the percentage of people noticing the tweet, Z: the percentage of people clicking on the tweet once they notice it. My concern is that people might read the content on the image (no value) more than the content of the tweet (value), in the end, not click on it to read the content in more depth. So in the current model (order of magnitudes) Y = 85, Z = 15, a conversion of 13% while in my proposal Y = 80, Z = 18, a conversion of 14%. Is this model true? I don't know, but food for thought.

@danilo-leal
Copy link
Contributor Author

it needs a card.png

Does the social card/image need to be within the markdown file, at the start of it, like in this 2021 post?

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 13, 2022

@danilo-leal I'm doing the change with a new commit to illustrate the process once. I think that it will be simpler to describe it.

@danilo-leal
Copy link
Contributor Author

@oliviertassinari cool, thanks! Are we good for merging? Feel like this one is 👍

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my end, a great step forward

@danilo-leal danilo-leal merged commit 7310d05 into mui:master Apr 14, 2022
@danilo-leal danilo-leal deleted the blog-images-update branch April 14, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants