Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add responsive AppBar with drawer #32769

Merged
merged 2 commits into from Jun 13, 2022
Merged

[docs] Add responsive AppBar with drawer #32769

merged 2 commits into from Jun 13, 2022

Conversation

dvlprAlamin
Copy link
Contributor

@dvlprAlamin dvlprAlamin commented May 14, 2022 •
edited by oliviertassinari

@mui-bot
Copy link

mui-bot commented May 14, 2022 •
edited

No bundle size changes

Generated by 🚫 dangerJS against ab63156

mnajdova
mnajdova previously requested changes May 18, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @samuelsycamore is this worth adding?

@dvlprAlamin
Copy link
Contributor Author

The drawer is for responsive mode. when the screen size is small then the menu button will be visible on the left side of AppBar. After clicking this button drawer will be open.

@mnajdova
Copy link
Member

mnajdova commented Jun 8, 2022

I am leaving this up to @samuelsycamore to decide if we want to have it.

@mnajdova mnajdova dismissed their stale review June 8, 2022 11:22

Un-subscribing from the thread

@samuelsycamore
Copy link
Member

LGTM! 🙌 Thanks for this @dvlprAlamin! Sorry I missed it last month. I'm always happy to see more demos in the docs, and this one is great! Let's do it. 🚀

@mnajdova mnajdova changed the title [docs] add responsive AppBar with drawer [docs] Add responsive AppBar with drawer Jun 13, 2022
@mnajdova mnajdova merged commit 7d1a02a into mui:master Jun 13, 2022
@zannager zannager added the docs Improvements or additions to the documentation label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsycamore samuelsycamore samuelsycamore approved these changes

@mnajdova mnajdova mnajdova left review comments

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dvlprAlamin @mui-bot @mnajdova @samuelsycamore @zannager