[Tabs] Scroll by width of the first visible tab if only one tab is partially visible #32778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
oliviertassinari
added
PR: needs test
mnajdova
requested changes
May 18, 2022
There was a problem hiding this comment.
Nice! Based on https://codesandbox.io/s/scrollabletabsbuttonforce-material-demo-forked-bzqr8l?file=/package.json looks like the solution works. Let's add test to ensure we won't create another regression in the future.
|
@mnajdova Thanks for the review. The test I added in |
mnajdova
requested changes
May 27, 2022
frankkluijtmans
force-pushed
the
fix/tabs-horizontal-scroll
branch
from
7afd991
to
1ba73e8
Compare
frankkluijtmans
force-pushed
the
fix/tabs-horizontal-scroll
branch
5 times, most recently
from
4aba1c4
to
91bfa8b
Compare
mnajdova
reviewed
Jun 3, 2022
frankkluijtmans
force-pushed
the
fix/tabs-horizontal-scroll
branch
from
91bfa8b
to
18db977
Compare
mnajdova
reviewed
Jun 10, 2022
mnajdova
approved these changes
Jun 10, 2022
oliviertassinari
added
bug 🐛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you're not able to scroll tabs when the container is narrow enough to have only one tab (partially) visible. This is my proposed solution, which would scroll by the width of the first visible tab in such a case.
Fixes #32748