[Snackbar] Remove RTL direction specific logic
#32808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted to check this same thing when reviewing #31991 today. cc @ZeeshanTamboli The changes makes sense 👍 Let's just make sure we don't break this again in the future by adding a screenshot test. You can follow what is done in https://github.com/mui/material-ui/blob/master/test/regressions/fixtures/Tooltip/PositionedTooltipsRtl.js and add a new one under |
mnajdova
added
component: snackbar
|
@mnajdova thanks for the link. I added those regression files |
|
Preview to test manually: https://deploy-preview-32808--material-ui.netlify.app/material-ui/react-snackbar/#main-content |
I will take a look. Will remove the |
ZeeshanTamboli
changed the title
RTL direction specific logic
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
added a commit
to ZeeshanTamboli/material-ui
that referenced
this pull request
May 20, 2022
mnajdova
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The Mui page guidelines for RTL are to use the
stylis-plugin-rtl(https://mui.com/material-ui/guides/right-to-left/) which handles rewriting directional css properties automatically. With RTL being handled within the component,styliswill assume LTR styles, even though they are already RTL. So it transforms the styles, which will result in LTR.To avoid this issue, one has to remove RTL handling within the component.
Fixes #32794