Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improvements for Radio Group Rating Docs #32843

Merged
merged 4 commits into from Jun 8, 2022
Merged

Conversation

Kai-W
Copy link
Contributor

@Kai-W Kai-W commented May 20, 2022

Added getLabelText
Added per Icon Colors

I noticed that the labels were prepared but not used. And for a project i needed the icons to be colored. It was not as straight forward as i thought so i decided to include it in the docs.

@mui-bot
Copy link

mui-bot commented May 20, 2022

No bundle size changes

Generated by 🚫 dangerJS against 27b438e

@Kai-W Kai-W changed the title Improvements for Radio Group Rating Docs [docs] Improvements for Radio Group Rating Docs May 20, 2022
Added getLabelText
Added per Icon Colors
@Kai-W
Copy link
Contributor Author

Kai-W commented Jun 1, 2022

Can somebody have a look at the failed test? I changed the color of the icons so the fail is expected, but i don't know how to change the test.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks!

@mnajdova mnajdova added docs Improvements or additions to the documentation component: rating This is the name of the generic UI component, not the React module! labels Jun 8, 2022
@mnajdova mnajdova merged commit e0e8197 into mui:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: rating This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants