Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] Allow state prefix to be configurable #32972

Merged
merged 15 commits into from Jun 23, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 1, 2022

Currently, Joy component className contains Mui as a global state prefix, eg. Mui-focusVisible.

This PR allows Joy to customize the global state prefix to Joy-focusVisible, Joy-checked, etc.

The change does not affect Material UI components (the prefix is default as Mui)

I will update all Joy components to have Joy prefix after the review to make it easier for the reviewer. Done!


@siriwatknp siriwatknp added package: joy-ui Specific to @mui/joy package: utils (private) Specific to the private @mui/utils package labels Jun 1, 2022
@mui-bot
Copy link

mui-bot commented Jun 1, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 9404b2d

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good 👍

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siriwatknp
Copy link
Member Author

Do we need a guide for Joy similar to https://mui.com/material-ui/customization/how-to-customize/#state-classes?

Yep, good point. I have added to the backlog and will work on it in a separate PR.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 15, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 15, 2022
@siriwatknp siriwatknp requested a review from mnajdova June 15, 2022 08:59
@siriwatknp siriwatknp merged commit aac7888 into mui:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: joy-ui Specific to @mui/joy package: utils (private) Specific to the private @mui/utils package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants