[core] Improve CONTRIBUTING.md local install instructions #32975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need review @samuelsycamore |
samuelsycamore
requested changes
Jun 6, 2022
There was a problem hiding this comment.
I have left some suggestions for style and grammar.
Additionally, I think this section needs further elaboration. I'm not familiar with this kind of workflow, and I am not able to reproduce it just by following the instructions here. Can you add more details?
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
|
Can you share which part are you getting stuck on or which part do you need more clarification? |
|
@samuelsycamore Made some changes. |
There was a problem hiding this comment.
Thanks @Moizsohail! I was able to make it work after following the instructions this time around. 🙌 I've just added some small changes for style consistency.
samuelsycamore
approved these changes
Jun 9, 2022
|
How will this get merged now? |
mnajdova
approved these changes
Jun 10, 2022
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing and debugging locally was a huge hassle and was very time consuming, especially for a beginner like me who has to console.log everything to understand what's going on. These instructions, will help save a lot of time debugging user changes.
Furthermore, these changes can later further be incorporated into a script to automate the whole process.