Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Add typography and link docs #33047

Merged
merged 14 commits into from Jun 9, 2022
Merged

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 6, 2022

Preview:

This PR also fixes the misuse of the variant for the Link.


@siriwatknp siriwatknp added component: Typography The React component. docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy and removed component: Typography The React component. labels Jun 6, 2022
@mui-bot
Copy link

mui-bot commented Jun 6, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 8d2893b

@siriwatknp siriwatknp marked this pull request as ready for review June 7, 2022 03:25
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 7, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 8, 2022
lg: '1.125',
lg: '1.125rem',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the font size does not have a unit which does not work in CSS.

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me for a first pass!

@siriwatknp siriwatknp merged commit 54da530 into mui:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants