Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add notification for Joy blog post #33059

Merged
merged 4 commits into from Jun 8, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 7, 2022

This PR should be merged after the release of the blog post.

Screen Shot 2565-06-07 at 21 38 30


@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Jun 7, 2022
@mui-bot
Copy link

mui-bot commented Jun 7, 2022

No bundle size changes

Generated by 🚫 dangerJS against b1122a7

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just refining it up! Let's wait for Sam's review and the tweets to go up to merge this one!

docs/notifications.json Outdated Show resolved Hide resolved
docs/notifications.json Outdated Show resolved Hide resolved
@danilo-leal
Copy link
Contributor

danilo-leal commented Jun 7, 2022

Also, kinda (but maybe not that much) off-topic, we might need to think about a max number of notifications we want to have in the docs (that scrollbar is getting long!). I'm feeling like 3 is a good number, but maybe even less?! In that sense, should we remove the ones that are there pilling up below the container's fold?

@samuelsycamore
Copy link
Member

Also, kinda (but maybe not that much) off-topic, we might need to think about a max number of notifications we want to have in the docs (that scrollbar is getting long!). I'm feeling like 3 is a good number, but maybe even less?! In that sense, should we remove the ones that are there pilling up below the container's fold?

3 makes sense to me. 👍

@siriwatknp
Copy link
Member Author

@danilo-leal Are we good to merge this PR?

@danilo-leal
Copy link
Contributor

Not quite yet, I'd say! The notification is up at the moment we merge it, right? We should wait for the tweet—it'll be up today (Wednesday) or Thursday tops.

@siriwatknp
Copy link
Member Author

siriwatknp commented Jun 8, 2022

I'd say! The notification is up at the moment we merge it, right?

Yes, that's right.

We should wait for the tweet—it'll be up today (Wednesday) or Thursday tops.

Got it.

@danilo-leal danilo-leal merged commit d05dfcf into mui:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants