Alpha 85 throws console errors in tests that 84 does not

[httpete]

With 85 in my jest tests I get this, with 84 smooth and nice.

      Warning: forwardRef render functions accept exactly two parameters: props and ref. Did you forget to use the ref parameter?
      at printWarning (node_modules/react/cjs/react.development.js:207:30)
      at error (node_modules/react/cjs/react.development.js:181:7)
      at Object.forwardRef (node_modules/react/cjs/react.development.js:1473:9)
      at Object.<anonymous> (node_modules/@mui/lab/node/CalendarPicker/CalendarPicker.js:34:43)

[mnajdova]

cc @flaviendelangle maybe we should have used React.forwardRef for the wrappers, but I am not sure if it is worth fixing. Note that the pickers are moving from @mui/lab to @mui/x, for more info on this - https://mui.com/blog/lab-date-pickers-to-mui-x/#how-do-i-migrate You may want to migrate them. There is a codemod for this too.

[mnajdova]

I am marking as wontfix, but will let Flavien have the final decision.

[flaviendelangle]

We have the exact same here #33080 for LoadingButton so I think there is something to fix

[masterambi]

We have the exact same here #33080 for LoadingButton so I think there is something to fix

yeah me too

[httpete]

What’s really bad is - we aren’t even importing or using these calendar components. Something really changed .

…

On Jun 10, 2022, at 7:52 AM, Ramzy Rashaun Arief ***@***.***> wrote:  We have the exact same here #33080 for LoadingButton so I think there is something to fix yeah me too — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[erdalstk]

What’s really bad is - we aren’t even importing or using these calendar components. Something really changed .
…
On Jun 10, 2022, at 7:52 AM, Ramzy Rashaun Arief @.***> wrote:  We have the exact same here #33080 for LoadingButton so I think there is something to fix yeah me too — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

exactly, same for me.

[ddolcimascolo]

Same here guys. I do import pickers from mui-x but I still have the lab for another component (TabContext from the top of my mind) and my tests are now full of this warning...

I can provide further logs, context, reproduction repo if that's worth it. Feel free to ask

Cheers,
David

[ddolcimascolo]

@flaviendelangle @mnajdova Should you remove the won't fix label?

[Nefcanto]

I'm getting this too. Without doing anything. I just updated my docker image and reinstalled everything and now I get it for DatePicker.js.

[cherniavskii]

@Nefcanto can you provide an example reproducing the issue? You can start with this demo: https://codesandbox.io/s/2s7m0n?file=/demo.tsx

[cherniavskii]

Should be fixed by #33107

[mnajdova]

Should be fixed by #33107

Not really, the problem with LoadingButton is still there.

[mnajdova]

Found the problem, one more components need to forward a ref. Creating a PR.