[Grid] Fix prop-type key regression

[oliviertassinari]

Fix #31998 (comment), first commit at the surface, the second commit at the root.

[mui-bot]

Details of bundle changes

Generated by 🚫 dangerJS against 0d498c2

[oliviertassinari]

data.prop.jsDoc === '@ignore' is because we have a custom prop-type for the key in

material-ui/packages/mui-material/src/Snackbar/Snackbar.js

Lines 332 to 338 in d66f1b6

	/**
	* When displaying multiple consecutive Snackbars from a parent rendering a single
	* <Snackbar/>, add the key prop to ensure independent treatment of each message.
	* e.g. <Snackbar key={message} />, otherwise, the message may update-in-place and
	* features such as autoHideDuration may be canceled.
	*/
	key: () => null,

[oliviertassinari]

@ignore is applied when there are no prop descriptions:

material-ui/scripts/generateProptypes.ts

Lines 209 to 213 in d66f1b6

	!prop.jsDoc ||
	(ignoreExternalDocumentation[component.name] &&
	ignoreExternalDocumentation[component.name].includes(prop.name))
	) {
	prop.jsDoc = '@ignore';

[oliviertassinari]

it's a boolean, so either true, false, null, or undefined.

[oliviertassinari]

This is why the key prop was added. TypeScript has some dark magic that makes him think that a key prop might be present here. If you remove key in propsRest then we are good. As a side note, we might have preferred using propsRest.hasOwnProperty(key) over key in propsRest systemically per https://masteringjs.io/tutorials/fundamentals/hasownproperty.

In our case, I could get away with only a nullish check.

[mnajdova]

hasOwnProperty makes sense too, but the nullish check reads better to me 👍