New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Remove empty tags on the TransferList demos #33127
Conversation
I can see the same in the |
@mnajdova I have also fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a broken closing tag, it is a self closing tag. Removing it broke the demo, for example try the basic demo - https://deploy-preview-33127--material-ui.netlify.app/material-ui/react-transfer-list/#basic-transfer-list. I am closing it, sorry for the initial misleading comment.
I checked it again and I still think it contains unnecessary tags. <- it's not broken, but unnecessary. The demo did not appear to be broken either. Could you to check it again?
|
The demo is broken in https://deploy-preview-33127--material-ui.netlify.app/material-ui/react-transfer-list/#basic-transfer-list, for example try to move the first list item to the right. |
@ekusiadadus I was refering to the example in the PR: https://deploy-preview-33127--material-ui.netlify.app/material-ui/react-transfer-list/#basic-transfer-list I can't see if the code on your side is changed, but it is clearly broken on the PR preview: |
Thanks for your review and sample movie. You clicked 'Transfer All Item' button, is it right? If you want to transfer only selected items, please click the button below. I've checked my code and preview again, and still I think this code works correct. |
🤦♀️ you are right, I kept pressing the Trasfer all button for some reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, it was my bad :)
Why
I found a JSX closing tag error in docs about TransferList and fixed it.
material-ui/docs/data/material/components/transfer-list/TransferList.tsx
Line 89 in 60eaa3b