[website] Fix navigation menu close behavior #33203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
| onFocus={() => setSubMenuOpen(true)} | ||
| onMouseOut={() => setSubMenuOpen(false)} | ||
| onBlur={() => setSubMenuOpen(false)} | ||
| onMouseEnter={() => setSubMenuOpenUndebounce('products')} |
There was a problem hiding this comment.
@siriwatknp I think that we should default to onMouseEnter/onMouseLeave over onMouseOver/onMouseOut because the latter fires unnecessarily more often https://stackoverflow.com/questions/1638877/difference-between-onmouseover-and-onmouseenter.
| style={{ zIndex: 1200, pointerEvents: subMenuOpen ? 'visible' : 'none' }} | ||
| style={{ | ||
| zIndex: 1200, | ||
| pointerEvents: subMenuOpen === 'products' ? undefined : 'none', |
There was a problem hiding this comment.
The default value of pointer-events is 'auto' not 'visible'. Also 'visible' only makes sense in the context of an SVG element, not for a div. Instead, we can unset the value. https://developer.mozilla.org/en-US/docs/Web/CSS/pointer-events
siriwatknp
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was first surfaced in #33125 (comment):
20220614-115713-413.mp4
I have implemented the solution suggested in #33125 (comment). I didn't try https://bjk5.com/post/44698559168/breaking-down-amazons-mega-dropdown as it feels overkill.
I can reproduce the same UX problem on https://stripe.com/en-fr and https://www.radix-ui.com/docs/primitives/components/navigation-menu we are a taking a step ahead :).
Preview: https://deploy-preview-33203--material-ui.netlify.app/