Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Fix crash when used with React 18 & Suspense #33277

Merged
merged 1 commit into from Jun 24, 2022

Conversation

mnajdova
Copy link
Member

Fixes #33276 (the last ResizeObserver handler called when Suspense replaces the component with the fallback had null for the refs, so we need to add this check before invoking any code that may access some of the refs).

Similar to #33238

@mnajdova mnajdova requested a review from siriwatknp June 24, 2022 07:55
@mui-bot
Copy link

mui-bot commented Jun 24, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 7e982e4

@mnajdova mnajdova added bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! labels Jun 24, 2022
@mnajdova mnajdova merged commit 66ff196 into mui:master Jun 24, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs] Components crashed when used with React 18 & Suspense
3 participants