[Slider] Fix incorrect marks displayed due to duplicate keys in range #33526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Thanks! Could you please check if this issue appears also in unit test and, if yes, create a test that verifies the fix? |
oliviertassinari
requested review from
michaldudak and
mnajdova
as code owners
oliviertassinari
added
component: slider
mnajdova
reviewed
Sep 26, 2022
mnajdova
approved these changes
Sep 29, 2022
mnajdova
changed the title
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
|
Nice bug fix 👌, I didn't anticipate this when I wrote the logic in #15703. I cleaned up a bit the label and PR title |
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31960
Description of the issue
Issue is caused when slider has more than one mark with the same value causing a duplicate key error. For example, when the lower limit and the upper limit thumbs in the range slider (marks are displayed for the thumb positions) are placed at the same position 100, both thumbs have the same key
100, causing issues with rendering sliders marks correctly.What fix was adopted?
The fix was to replace the key value to mark index instead of mark value.