Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skeleton] Add rounded variant #33687

Merged
merged 2 commits into from Aug 2, 2022
Merged

[Skeleton] Add rounded variant #33687

merged 2 commits into from Aug 2, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jul 29, 2022 •
edited by oliviertassinari

@siriwatknp siriwatknp added new feature New feature or request package: material-ui Specific to @mui/material component: skeleton This is the name of the generic UI component, not the React module! labels Jul 29, 2022
@siriwatknp siriwatknp requested a review from mnajdova July 29, 2022 02:59
@mui-bot
Copy link

mui-bot commented Jul 29, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against f7deddb

@siriwatknp siriwatknp mentioned this pull request Jul 29, 2022
Closed
1 task
@ZeeshanTamboli
Copy link
Member

Just chiming in, we need to update the variant prop type and then it's API docs.

@siriwatknp
Copy link
Member Author

Just chiming in, we need to update the variant prop type and then it's API docs.

Done! nice catch

hbjORbj
hbjORbj approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@siriwatknp siriwatknp merged commit 4e5e2a7 into mui:master Aug 2, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@siriwatknp
[Skeleton] Add rounded variant (mui#33687)
0983d90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: skeleton This is the name of the generic UI component, not the React module! new feature New feature or request package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skeleton: rounded variant
4 participants
@siriwatknp @mui-bot @ZeeshanTamboli @hbjORbj