[docs] Enforce description for all pages #33698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
flaviendelangle
approved these changes
Aug 11, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mui.com/x/api/data-grid/grid-export-state-params/ is the only page of on mui.com that doesn't have a description. See ahrefs explanation for why we probably want to have one on all the pages. I'm fixing the problem on the surface with: mui/mui-x#5654. It surfaced in an SEO crawl.
But the main reason why I worked on this is that it seems to be a quick-win opportunity. With this PR we should be able to solve the problem at the root, to have mui/mui-x#5390 CI fail, it's easy to miss.
A shorter feedback loop and one less thing to think about :).
Soon or later, I would need to delegate my ownership of the SEO execution quality of mui.com. It's increasingly harder for me to find time to work on this.