Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[useScrollTrigger] Add passive flag to scroll trigger event listener #32437 #33749

Merged
merged 1 commit into from Aug 8, 2022
Merged

[useScrollTrigger] Add passive flag to scroll trigger event listener #32437 #33749

merged 1 commit into from Aug 8, 2022

Conversation

Dsalazar1685
Copy link
Contributor

Closes #32437

@mui-bot
Copy link

mui-bot commented Aug 2, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against dc48e8c

@michaldudak
Copy link
Member

This seems to be working fine.
One small issue is that IE will interpret the third argument as useCapture (it doesn't support passive event handlers) and treat the object passed in as true. This shouldn't really matter in this particular case, so I'm OK with keeping this as proposed.
@oliviertassinari - are you fine with this approach?

@oliviertassinari
Copy link
Member

For IE 11, the idea in https://mui.com/material-ui/getting-started/supported-platforms/#ie-11 is to say it's something we will do tradeoffs against. So trading degraded IE 11 support in exchange for better support of new browsers, yeah, that sounds like a great deal 💸.

michaldudak
michaldudak approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it :)

@siriwatknp siriwatknp merged commit a804ca8 into mui:master Aug 8, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@Dsalazar1685
[useScrollTrigger] Add passive flag to scroll trigger event listener m…
63f708e 
…ui#32437  (mui#33749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
hook: useScrollTrigger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[useScrollTrigger] Make it scroll event handler passive
5 participants
@Dsalazar1685 @mui-bot @michaldudak @oliviertassinari @siriwatknp