Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid] Export interface RegularBreakpoints to fix type error #33751

Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Aug 2, 2022

Fixes #33165

This issue occurs only for library apps where it is needed to generate declaration files (.d.ts) with declaration: true set in it's tsconfig.

Explained well in #33165 (comment)

Discussion about this in TypeScript repo: microsoft/TypeScript#5711


Before: https://codesandbox.io/s/trusting-water-wxupl4?file=/src/App.tsx

After: https://codesandbox.io/s/create-react-app-with-typescript-forked-iupbvd?file=/src/App.tsx

@mui-bot
Copy link

mui-bot commented Aug 2, 2022

No bundle size changes

Generated by 🚫 dangerJS against 3fd478f

@ZeeshanTamboli ZeeshanTamboli changed the title [Grid] Export interface RegularBreakpoints for generating valid declaration file [Grid] Export interface RegularBreakpoints Aug 2, 2022
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: Grid The React component. typescript labels Aug 2, 2022
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review August 2, 2022 06:19
@ZeeshanTamboli ZeeshanTamboli changed the title [Grid] Export interface RegularBreakpoints [Grid] Export interface RegularBreakpoints to fix type error Aug 2, 2022
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ZeeshanTamboli ZeeshanTamboli merged commit 35072a2 into mui:master Aug 3, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the issue/33165-grid-RegularBreakpoints branch August 3, 2022 04:53
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Grid The React component. typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a styled(Grid) results in an error from 'RegularBreakpoints'
3 participants