[core] Clear yarn installation warning #33776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
reviewed
Aug 10, 2022
package.json
Outdated
| @@ -209,6 +209,7 @@ | |||
| "**/@babel/preset-react": "^7.16.7", | |||
| "**/@babel/preset-typescript": "^7.16.7", | |||
| "**/@babel/runtime": "^7.17.2", | |||
| "**/@definitelytyped/typescript-versions": "^0.0.121", | |||
There was a problem hiding this comment.
Can you share more info on why you landed on this version and why this fixes the issue?
There was a problem hiding this comment.
dtslint specifies its dependency on @definitelytyped/typescript-versions as latest, which leads to this problem. Having the version resolved this way doesn't really change the version used but eliminates the warning.
0.0.121 was the latest version of this package when I authored this PR (it changed since - I'll update it in a bit).
I've seen this problem in other projects as well: thefrontside/bigtest#469
mnajdova
approved these changes
Aug 11, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following warning appearing in the terminal when installing yarn packages: