[Grid] Prevent crash if spacing is set to zero in theme #33777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you review this PR please ? |
siriwatknp
reviewed
Aug 4, 2022
There was a problem hiding this comment.
@PunitSoniME Thanks for the contribution. See my comment #33771 (comment) for better understanding as to why it is happening.
We will also need to add a test in Grid (Check the CodeSandbox in the above linked comment).
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
changed the title
density tool crashing
ZeeshanTamboli
changed the title
density tool crashing
siriwatknp
changed the title
|
@siriwatknp @PunitSoniME I have added a test and updated the PR description explaining the issue in #33771 (comment). Please take a look. |
|
I am changing the PR title to Grid instead. Ideally, this PR should be split into 2 @PunitSoniME thanks for fixing it. |
|
Thanks @ZeeshanTamboli Thanks @siriwatknp |
This comment was marked as spam.
This comment was marked as spam.
siriwatknp
approved these changes
Aug 5, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
* [docs] demo density tool crashes * [docs] prettier executed * [docs] code changed as per suggestions * add test Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33771
Preview - https://deploy-preview-33777--material-ui.netlify.app/material-ui/customization/density/
DensityTooldemo which uses the Grid from crashing thus resolving [docs] Demo DensityTool crashes #33771.More details in #33771 (comment).
Before: https://codesandbox.io/s/admiring-dirac-ctu7c1.
After: https://codesandbox.io/s/boring-agnesi-l7fmw1