[Stack][material] Use createStack from the system #33795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-33795--material-ui.netlify.app/ @material-ui/core: parsed: +0.09% , gzip: +0.11% Bundle size report |
mnajdova
added
package: material-ui
mnajdova
changed the title
mnajdova
commented
Aug 4, 2022
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "props": { | |||
| "children": { "type": { "name": "node" } }, | |||
| "component": { "type": { "name": "elementType" } }, | |||
There was a problem hiding this comment.
Oops this was missing in the prop types
mnajdova
commented
Aug 4, 2022
| @@ -6,7 +6,6 @@ import { Theme } from '../styles/createTheme'; | |||
| export interface StackTypeMap<P = {}, D extends React.ElementType = 'div'> { | |||
| props: P & | |||
| SystemProps<Theme> & { | |||
| ref?: React.Ref<unknown>; | |||
There was a problem hiding this comment.
Redundant, not sure why we had it here.
mnajdova
commented
Aug 4, 2022
siriwatknp
reviewed
Aug 5, 2022
mnajdova
added
package: material-ui
mnajdova
requested review from
hbjORbj,
danilo-leal,
michaldudak and
m4theushw
as code owners
|
@mnajdova I updated the material-ui-eslint to support the component factory. please check the latest commits. |
|
@siriwatknp it's been a long time on this PR :D I've updated to latest master, should we merge it? |
siriwatknp
reviewed
Feb 23, 2023
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com> Signed-off-by: Marija Najdova <mnajdova@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-33795--material-ui.netlify.app/material-ui/react-stack/