Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TableCell] Enable size prop overrides via module augmentation #33816

Merged
merged 5 commits into from Aug 8, 2022
Merged

[TableCell] Enable size prop overrides via module augmentation #33816

merged 5 commits into from Aug 8, 2022

Conversation

brentertz
Copy link
Contributor

@brentertz brentertz commented Aug 5, 2022

Enable TableCell size prop overrides via module augmentation using pattern recommend in #33802 (comment).

Fixes #33802

@mui-bot
Copy link

mui-bot commented Aug 5, 2022

No bundle size changes

Generated by 🚫 dangerJS against faa0d84

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your first contribution!

Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the size prop type in TableCell. Here is an example of how it should be:

size: PropTypes /* @typescript-to-proptypes-ignore */.oneOfType([
PropTypes.oneOf(['medium', 'small']),
PropTypes.string,
]),

Then update the API docs.

@siriwatknp siriwatknp merged commit fd249d5 into mui:master Aug 8, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@zannager zannager added the component: table This is the name of the generic UI component, not the React module! label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TablePropsSizeOverrides customization via module augmentation
5 participants