[core] Remove outdated Next.js options #33845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
commented
Aug 7, 2022
There was a problem hiding this comment.
For the warning standing, it's a regression, fixed in vercel/next.js#39171.
| ignoreBuildErrors: true, | ||
| }, | ||
| webpack5: true, |
There was a problem hiding this comment.
Webpack 4 was removed in Next.js v12 https://github.com/vercel/next.js/blob/37d11008250b3b87dfa4625cd228ac173d4d3563/errors/webpack5.md
| @@ -33,10 +33,8 @@ module.exports = { | |||
| }, | |||
| typescript: { | |||
| // Motivated by https://github.com/vercel/next.js/issues/7687 | |||
| ignoreDevErrors: true, | |||
There was a problem hiding this comment.
Removed in vercel/next.js#12941
(I hate this kind of PRs, when you look at it, you have no idea why ignoreDevErrors is gone. And of course, the PR is locked, so you can't ask, it sounds like it was decided on a private channel, perfect to engage with the community)
oliviertassinari
added
docs
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to check the logs server side, and here is what I got, too much noise for my taste 馃榿:
It comes from #33626