Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update transform function in the sx prop sizing docs #33850

Merged
merged 2 commits into from Aug 10, 2022
Merged

[docs] Update transform function in the sx prop sizing docs #33850

merged 2 commits into from Aug 10, 2022

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Aug 8, 2022 •
edited

@ZeeshanTamboli ZeeshanTamboli added the docs Improvements or additions to the documentation label Aug 8, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Update transform function in sizing docs [docs] Update transform function in the sx prop sizing docs Aug 8, 2022
@mui-bot
Copy link

mui-bot commented Aug 8, 2022 •
edited

No bundle size changes

Generated by 🚫 dangerJS against 8c8fd57

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 9, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 9, 2022
mnajdova
mnajdova reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share an issue about what is the problem and why the change was made? 0% or 0px doesn't seem that important in my opinion. Also, we would need to add tests if this actually creates a problem.

@ZeeshanTamboli
Copy link
Member Author

ZeeshanTamboli commented Aug 10, 2022 •
edited

Can you share an issue about what is the problem and why the change was made? 0% or 0px doesn't seem that important in my opinion. Also, we would need to add tests if this actually creates a problem.

There is no issue. Just saw that the transform function in the implementation and the docs is different. Check for 0 was added in #28219. Tests were also covered there.

It's just a minor thing really. Basically, docs matching the code.

@mnajdova mnajdova merged commit db6c358 into mui:master Aug 10, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the update-code-example-sizing-docs branch August 10, 2022 12:53
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@ZeeshanTamboli
[docs] Update transform function in the sx prop sizing docs (mui#33850)
dba8601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZeeshanTamboli @mui-bot @mnajdova