Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TableCell] Enable variant overrides via TypeScript module augmentation #33856

Merged
merged 4 commits into from Aug 9, 2022
Merged

[TableCell] Enable variant overrides via TypeScript module augmentation #33856

merged 4 commits into from Aug 9, 2022

Conversation

arjunvkurup
Copy link
Contributor

@arjunvkurup arjunvkurup commented Aug 8, 2022 •
edited by ZeeshanTamboli

Fixes #33793

@mui-bot
Copy link

mui-bot commented Aug 8, 2022 •
edited

No bundle size changes

Generated by 🚫 dangerJS against cdd0b8f

@ZeeshanTamboli ZeeshanTamboli changed the title [TableCell] Enable variant overrides (#33793) [TableCell] Enable variant overrides via TypeScript module augmentation Aug 8, 2022
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! typescript labels Aug 8, 2022
@arjunvkurup
Copy link
Contributor Author

@ZeeshanTamboli, can you check the deployment issue?

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Aug 9, 2022 •
edited

@ZeeshanTamboli, can you check the deployment issue?

There is no issue I guess. Just trigger the CI again by merging latest master branch into this branch.

ZeeshanTamboli
ZeeshanTamboli reviewed Aug 9, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

siriwatknp
siriwatknp approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution! and @ZeeshanTamboli for helping.

@ZeeshanTamboli ZeeshanTamboli merged commit 8db323e into mui:master Aug 9, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@arjunvkurup
[TableCell] Enable variant overrides via TypeScript module augmentati…
9e9df5c 
…on (mui#33856)

* [TableCell] Enable variant overrides (mui#33793)

* added prettier (mui#33793)

* fix redundant module declaration
@MickaelAustoni MickaelAustoni mentioned this pull request Dec 15, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overriding MuiTableCell using variants gives "Failed prop type" warning
4 participants
@arjunvkurup @mui-bot @ZeeshanTamboli @siriwatknp