Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy] Add tests / classes for Breadcrumbs component #33860

Merged
merged 10 commits into from Aug 30, 2022
Merged

[Joy] Add tests / classes for Breadcrumbs component #33860

merged 10 commits into from Aug 30, 2022

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Aug 8, 2022 •
edited

This PR includes:

  • unit tests for size prop
  • conformance tests
  • typescript test
  • addition of classes for size prop

@hbjORbj hbjORbj requested a review from siriwatknp August 8, 2022 16:20
@hbjORbj hbjORbj self-assigned this Aug 8, 2022
@hbjORbj hbjORbj added test component: breadcrumbs This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Aug 8, 2022
@mui-bot
Copy link

mui-bot commented Aug 8, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against b206b01

@hbjORbj hbjORbj force-pushed the joy/breadcrumbs-enhancement branch from 72c24b1 to 956dac0 Compare August 29, 2022 10:28
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 29, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 29, 2022
siriwatknp
siriwatknp approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nicely done!

@hbjORbj hbjORbj merged commit f8a1779 into mui:master Aug 30, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@hbjORbj
[Joy] Add tests / classes for Breadcrumbs component (mui#33860)
0a7693f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@danilo-leal danilo-leal Awaiting requested review from danilo-leal

Assignees

@hbjORbj hbjORbj

Labels
component: breadcrumbs This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hbjORbj @mui-bot @siriwatknp