Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input][base] Pass the rows prop to the underlying textarea #33873

Merged
merged 3 commits into from Aug 10, 2022
Merged

[Input][base] Pass the rows prop to the underlying textarea #33873

merged 3 commits into from Aug 10, 2022

Conversation

michaldudak
Copy link
Member

Made sure props related to multiline input (rows, minRows, maxRows) are correctly passed in to the underlying Textarea lot.

Fixes #33060

@michaldudak michaldudak added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Aug 9, 2022
@michaldudak michaldudak requested a review from a team August 9, 2022 13:51
@mui-bot
Copy link

mui-bot commented Aug 9, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 7f1e5e3

@michaldudak michaldudak changed the title [InputUnstyled] Pass the rows prop to the underlying textarea [Input][base] Pass the rows prop to the underlying textarea Aug 9, 2022
mnajdova
mnajdova approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems like the tests cover all cases now 👍

@michaldudak michaldudak enabled auto-merge (squash) August 10, 2022 10:52
@michaldudak michaldudak merged commit f4b3a45 into mui:master Aug 10, 2022
@michaldudak michaldudak deleted the issues/33060-input-forwarding-rows-prop branch August 17, 2022 07:21
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@michaldudak
[Input][base] Pass the rows prop to the underlying textarea (mui#33873)
9659a39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[InputUnstyled] not forwarding textarea specific props (rows, maxRows, minRows)
3 participants
@michaldudak @mui-bot @mnajdova