[Button][base] Prevent too many ref updates #33882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
bug 🐛
hbjORbj
approved these changes
Aug 11, 2022
michaldudak
force-pushed
the
iss/33457-useSelect-mobile-crash
branch
from
fabfb0d
to
a110cd6
Compare
|
@mnajdova The issue solved by this PR occurs only on mobile Chrome. I wasn't able to reproduce it in our unit tests. |
mnajdova
approved these changes
Aug 29, 2022
1 task
1 task
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ref callback is
useButtonwas not a stable reference and thus was called too often. It caused issues, as it sets the state inside.This PR wraps it in
useCallback, preventing the problem.Fixes #33457