Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IconButton][Joy] Fix large IconButton scaling #33885

Merged
merged 1 commit into from Aug 15, 2022
Merged

[IconButton][Joy] Fix large IconButton scaling #33885

merged 1 commit into from Aug 15, 2022

Conversation

cherewaty
Copy link
Contributor

@cherewaty cherewaty commented Aug 10, 2022 •
edited

This was probably a typo in #33750

Before

before

After

after

@mui-bot
Copy link

mui-bot commented Aug 10, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 70489ac

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Aug 11, 2022
siriwatknp
siriwatknp approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch!

@siriwatknp siriwatknp added bug 🐛 Something doesn't work and removed docs Improvements or additions to the documentation labels Aug 15, 2022
@siriwatknp siriwatknp changed the title [joy] Fix large IconButton scaling [IconButton][Joy] Fix large IconButton scaling Aug 15, 2022
@siriwatknp siriwatknp added the component: icon button This is the name of the generic UI component, not the React module! label Aug 15, 2022
@siriwatknp
Copy link
Member

Seems like it is worth having sizes demo for all Joy components. I will do it in batch in a separate PR.

@siriwatknp siriwatknp merged commit e79f0e3 into mui:master Aug 15, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@cherewaty
[IconButton][Joy] Fix large IconButton scaling (mui#33885)
b53e5c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: icon button This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cherewaty @mui-bot @siriwatknp @ZeeshanTamboli