Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix typo in Joy UI's AspectRatio docs #33895

Merged
merged 2 commits into from Aug 15, 2022
Merged

[docs] Fix typo in Joy UI's AspectRatio docs #33895

merged 2 commits into from Aug 15, 2022

Conversation

IsaacInsoll
Copy link
Contributor

@IsaacInsoll IsaacInsoll commented Aug 12, 2022 •
edited by oliviertassinari

@IsaacInsoll
apect-ratio.md - fix typo
0a1e4cf 
Signed-off-by: IsaacInsoll <30609296+IsaacInsoll@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Aug 12, 2022 •
edited

No bundle size changes

Generated by 🚫 dangerJS against d636214

@ZeeshanTamboli ZeeshanTamboli added the docs Improvements or additions to the documentation label Aug 12, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title apect-ratio.md - fix typo [docs][joy] Fix typo in Aspect ratio docs Aug 12, 2022
@ZeeshanTamboli ZeeshanTamboli added the package: joy-ui Specific to @mui/joy label Aug 12, 2022
@danilo-leal danilo-leal changed the title [docs][joy] Fix typo in Aspect ratio docs [docs] Fix typo in Joy UI's AspectRatio docs Aug 12, 2022
danilo-leal
danilo-leal approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! 👌

oliviertassinari
oliviertassinari reviewed Aug 13, 2022
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the missing spacing and the use of "we":

docs/data/joy/components/aspect-ratio/aspect-ratio.md Outdated Show resolved Hide resolved
docs/data/joy/components/aspect-ratio/aspect-ratio.md Outdated Show resolved Hide resolved
@mnajdova @oliviertassinari
Apply suggestions from code review
d636214 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova mnajdova merged commit 025e6fb into mui:master Aug 15, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@IsaacInsoll
[docs] Fix typo in Joy UI's AspectRatio docs (mui#33895)
51d88bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@IsaacInsoll @mui-bot @oliviertassinari @mnajdova @danilo-leal @ZeeshanTamboli