Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Fix broken path to favicon.ico #33906

Merged
merged 2 commits into from Aug 13, 2022

Conversation

vegancat
Copy link
Contributor

@vegancat vegancat commented Aug 12, 2022

Update _document.tsx: Fix broken path to favicon.ico

  • Next is not serving static files from "/static" folder anymore. Instead all files inside public
    are accessible in pages.
  • Replace path "/static/favicon.ico" with "favicon.ico"

Signed-off-by: Vegan Cat

Update path to favicon.ico

- Next is not serving static files from "/static" folder anymore. Instead all files inside public
are accessible in pages.
- Replace path "/static/favicon.ico" with "favicon.ico"

Signed-off-by: Vegan Cat <mmostafavi247@gmail.com>
@mui-bot
Copy link

mui-bot commented Aug 12, 2022

No bundle size changes

Generated by 🚫 dangerJS against 0902a04

@vegancat vegancat changed the title Update _document.tsx: Fix broken path to favicon.ico [Examples] Update _document.tsx: Fix broken path to favicon.ico Aug 13, 2022
@oliviertassinari oliviertassinari changed the title [Examples] Update _document.tsx: Fix broken path to favicon.ico [examples] Fix broken path to favicon.ico Aug 13, 2022
@oliviertassinari oliviertassinari added examples Relating to /examples bug 🐛 Something doesn't work labels Aug 13, 2022
@oliviertassinari
Copy link
Member

@mmostafavi Thanks for the bug fix

@oliviertassinari oliviertassinari merged commit e88750f into mui:master Aug 13, 2022
@vegancat vegancat deleted the Fix-broken-path-to-favicon branch August 13, 2022 10:14
@vegancat
Copy link
Contributor Author

@oliviertassinari Happy to help

daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work examples Relating to /examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants