[core] Use proper external build id for Argos uploads #33929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work:
|
|
Looks good, |
|
@oliviertassinari this PR is in material-ui repo :) |
michaldudak
approved these changes
Aug 15, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MUI X sometimes we have false negative regressions like https://app.argos-ci.com/mui/mui-x/builds/3071
Currently, we have to push new commit (or rebase) to trigger whole CI pipeline and upload new screenshot to Argos.
But ideally we would like to restart a single step in the pipeline.
Turned out, we used wrong external build id as pointed out in argos-ci/argos#457 (comment)