[MultiSelect][base] Require a single tap to select an item on mobile Chrome #33932
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
bug 🐛
michaldudak
force-pushed
the
multiselect-mobile-double-tap-error
branch
from
6fd7e1a to
705d287
Compare
|
Can you link the issue that we are fixing? It would help with the review. I am asking because I can't see any issue on Chrome on iOS. |
|
There was no issue reported, I've noticed it myself. I'll create one for reference. |
mnajdova
approved these changes
Sep 26, 2022
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile Chrome emulates onMouseOver when an option is tapped. This causes both mouseover and click actions to be dispatched next to each other. The MultiSelect behavior is broken in such case. This PR changes the mouseover to pointerover (which is not emulated when tapping on an element), preventing the problem.
Fixes #34151