[website] Add Toolpad to Navigation #33937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
website
There was a problem hiding this comment.
- We are missing
/static/branding/product-toolpad-light.svg - In [website] Landing page mui-toolpad#809 we say that this PR should be merged first. Are we sure? I would expect a link to only be added once the page it links to is present.
Comment on lines
101
to
106
| { | ||
| name: 'MUI Toolpad', | ||
| description: 'Low-code tool builder, powered by MUI.', | ||
| href: ROUTES.toolpadDocs, | ||
| chip: 'Alpha', | ||
| }, |
There was a problem hiding this comment.
I wonder if the docs of Toolpad is mature enough to be linked 🤔
There was a problem hiding this comment.
My opinion is that we can include the Docs link later
|
I have pushed a change so that the new sections in the docs are only visible in staging ( |
bharatkashyap
changed the title
oliviertassinari
approved these changes
Aug 27, 2022
There was a problem hiding this comment.
I'm approving to not increase the review pressure on the core team.
Once mui/mui-toolpad#809 is merged, I think that we can remove the process.env.STAGING checks.
1 task
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's part of this effort: mui/mui-toolpad#809
Preview https://deploy-preview-33937--material-ui.netlify.app/.