Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Do not append types field to packages without index.d.ts #33952

Merged
merged 1 commit into from Aug 31, 2022

Conversation

michaldudak
Copy link
Member

The copy-files script adds `types: "./index.d.ts" to the built package.json, regardless of the existence of the type definition file. This PR changes the script to check if the d.ts file exists before adding the field.

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Aug 16, 2022
@mui-bot
Copy link

mui-bot commented Aug 16, 2022

No bundle size changes

Generated by 🚫 dangerJS against 9d17cbe

@michaldudak michaldudak requested a review from a team August 30, 2022 10:23
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@michaldudak michaldudak merged commit 5a3036a into mui:master Aug 31, 2022
@michaldudak michaldudak deleted the build-copy-types branch August 31, 2022 08:11
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants