Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Textarea][Joy] Add Textarea component #33975

Merged
merged 21 commits into from Aug 24, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Aug 18, 2022

Preview: https://deploy-preview-33975--material-ui.netlify.app/joy-ui/react-textarea/

Motivation

Even though input and textarea are quite similar but their props and default styles are different.

I don't think combining them like this is a good thing:

<TextField /> // renders <Input />
<TextField multiline /> // renders <Textarea />

This PR split the Textarea into its own component which removes the typescript headache and makes the component easier to reason about (closer to the native html).

In the next PR, it will be TextareaField which combines Textarea, FormLabel and FormHelperText.

The supported props and structure are consistent with the Input.


@siriwatknp siriwatknp added component: TextareaAutosize The React component. package: joy-ui Specific to @mui/joy labels Aug 18, 2022
@mui-bot
Copy link

mui-bot commented Aug 18, 2022

Details of bundle changes

@mui/joy: parsed: +3.62% , gzip: +3.04%

Generated by 🚫 dangerJS against 90ae674

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 22, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 23, 2022
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just pushed very minor tweaks but other than that, it's great!

@siriwatknp siriwatknp merged commit 41c97af into mui:master Aug 24, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: TextareaAutosize The React component. package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants