[core] Sanitize input in icon synonyms update script #33989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
docs
|
@siriwatknp, @oliviertassinari can I please have this PR reviewed? |
|
I have added the scope label, so we can more easily find others like this in the future. e.g, it looks like a follow up on #32742 👍 |
|
I haven't added it in the first place as the code lives in the docs directory, not in the icons package. But I'm OK with having it to indicate the change is related to icons. |
siriwatknp
approved these changes
Aug 31, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon metadata from https://fonts.google.com/metadata/icons contain tags that cause our script to produce invalid JS. Specifically, a few tags are surrounded by apostrophes. This fix removes any apostrophes found in the tags.
Additionally, it skips tags that are clearly invalid - ones that contain "Remove", "Duplicate", "Same as", "remove others", so these strings don't appear as synonyms.