New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Avatar] Use structured / semantic markup for avatars and avatar groups #33994
Conversation
Need some help updating the |
@paulschreiber Thanks for the PR but can you fix only the I think changing the semantics should be in v6. cc @mnajdova |
@siriwatknp I couldn't figure out the right component prop change. Can you make a push to the branch or GitHub code suggestion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply the suggested changes and run:
yarn proptypes
yarn docs:api
yarn prettier
We can't change the structure of the components in a minor, mainly because the avatar can be used outside of a group, which means that li
as a tag would be wrong in that case.
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Signed-off-by: Paul Schreiber <github@paulschreiber.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Signed-off-by: Paul Schreiber <github@paulschreiber.com>
@mnajdova @siriwatknp I pushed the other changes but am not sure what to do for the component prop. |
@mnajdova @siriwatknp component prop is updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the fix!
Use structured / semantic markup for avatars and avatar groups. Improves experience for screen reader users.
component
overriding to theAvatarGroup
component.Have(consider in v6)AvatarGroup
useul
by default.Have(consider in v6)Avatar
useli
by default.Fixes #33993.