[docs] Fix broken Joy UI codesandbox export #34007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was looking into a bug in https://mui.com/joy-ui/react-text-field/, so wanted to export a codesandbox with the first button that I could click on. The first one opened https://codesandbox.io/s/30i7kf?file=/demo.tsx which crash Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
added
docs
danilo-leal
approved these changes
Aug 22, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into a bug in https://mui.com/joy-ui/react-text-field/, I wanted to create a reproduction with codesandbox, so I went searching for the first button that I could click on. The first one opened https://codesandbox.io/s/30i7kf?file=/demo.tsx which crashed:
=> friction. I don't have the time to check if there are other broken demos like this in the docs of Joy UI. I wouldn't be surprised if there are more to fix.
Regarding the crash itself, I think that it's the expected behavior. The component the demo tries to import is internal to our docs.
Preview: https://deploy-preview-34007--material-ui.netlify.app/joy-ui/react-text-field/#introduction