Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FocusTrap] Improve tab test and simplify demo #34008

Merged
merged 3 commits into from Aug 23, 2022
Merged

[FocusTrap] Improve tab test and simplify demo #34008

merged 3 commits into from Aug 23, 2022

Conversation

EthanStandel
Copy link
Contributor

@EthanStandel EthanStandel commented Aug 21, 2022 •
edited by oliviertassinari

This PR resolves asks from after this PR: #33543 (review) merged. The associated issue can be seen here: #33380.

Preview: https://deploy-preview-34008--material-ui.netlify.app/base/react-trap-focus/

@EthanStandel EthanStandel changed the title [base] Move TrapFocus test to more sensible context, [docs] simplify docs for ContainedToggleTrappedFocus examples [base] Move TrapFocus test to more sensible context [docs] simplify docs for ContainedToggleTrappedFocus examples Aug 21, 2022
@EthanStandel EthanStandel changed the title [base] Move TrapFocus test to more sensible context [docs] simplify docs for ContainedToggleTrappedFocus examples [base] Move TrapFocus test to more sensible context & simplify docs for ContainedToggleTrappedFocus examples Aug 21, 2022
@mui-bot
Copy link

mui-bot commented Aug 21, 2022 •
edited

No bundle size changes

Generated by 🚫 dangerJS against f12f674

@EthanStandel EthanStandel mentioned this pull request Aug 21, 2022
Closed
2 tasks
@oliviertassinari oliviertassinari added component: FocusTrap The React component. docs Improvements or additions to the documentation test labels Aug 22, 2022
@oliviertassinari oliviertassinari changed the title [base] Move TrapFocus test to more sensible context & simplify docs for ContainedToggleTrappedFocus examples [TrapFocus] Improve test and simplify demo Aug 22, 2022
@oliviertassinari oliviertassinari changed the title [TrapFocus] Improve test and simplify demo [TrapFocus] Improve tab test and simplify demo Aug 22, 2022
oliviertassinari
oliviertassinari reviewed Aug 22, 2022
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks, I have pushed one more commit to:

  1. Reduce the number of lines in the demos, we can keep the sx properties on a single line
  2. Import from MUI System in the MUI Base documentation. Material Design is kind of off-topic in this environment.

michaldudak
michaldudak approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaldudak michaldudak merged commit 479663a into mui:master Aug 23, 2022
@oliviertassinari oliviertassinari changed the title [TrapFocus] Improve tab test and simplify demo [FocusTrap] Improve tab test and simplify demo Oct 23, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@EthanStandel @oliviertassinari
[TrapFocus] Improve tab test and simplify demo (mui#34008)
4b35e63 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
component: FocusTrap The React component. docs Improvements or additions to the documentation test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EthanStandel @mui-bot @oliviertassinari @michaldudak