[Autocomplete] Update unstyled demo to not import Material UI #34060
Conversation
oliviertassinari
added
docs
|
It looks like the CODEOWNERS logic fails on this one 😁. I had to manually check who owns this component: Marija and Michal, and since it's also about base, I picked the latter. |
| overflow: 'auto', | ||
| maxHeight: 200, | ||
| border: '1px solid rgba(0,0,0,.25)', | ||
| [`& li.${autocompleteClasses.focused}`]: { | ||
| '& li.Mui-focused': { |
There was a problem hiding this comment.
It's hardcoded anyway:
There was a problem hiding this comment.
useAutocomplete needs an overhaul to match the other hooks in Base. It uses different patterns now (like setting a class name, that doesn't happen anywhere else in other hooks).
There was a problem hiding this comment.
(like setting a class name, that doesn't happen anywhere else in other hooks).
@michaldudak What would be the alternative in this case? For context: #26181
needs an overhaul to match the other hooks in Base.
I think that it would be great for you to review mui/mui-x#5504. I wanted to raise how the unstyled hook API of the date picker feels a bit different from our useAutocomplete (the useAutocomplete API is a lot inspired by https://www.downshift-js.com/use-combobox).
It uses different patterns now
I think that this would be a great opportunity to review the differences, so we can only keep the best changes.
There was a problem hiding this comment.
@michaldudak Bump. I'm curious about two things:
- How is the pattern hook different now, e.g. developers seem to enjoy the current approach: https://twitter.com/shyam_lohar_/status/1571000213388791808 (which also makes the case for a headless first approach, anytime we create a new component, in Joy UI, Material UI, MUI X, we should likely start from the headless DX).
- How to align with MUI X on it, e.g. with @flaviendelangle [AutoComplete] dataSourceConfig not working #5504
There was a problem hiding this comment.
It looks like the CODEOWNERS logic fails on this one 😁. I had to manually check who owns this component: Marija and Michal, and since it's also about base, I picked the latter.
The CODEOWNERS file is missing the docs directory. That's why no one showed up as an owner of the changed files.
| overflow: 'auto', | ||
| maxHeight: 200, | ||
| border: '1px solid rgba(0,0,0,.25)', | ||
| [`& li.${autocompleteClasses.focused}`]: { | ||
| '& li.Mui-focused': { |
There was a problem hiding this comment.
useAutocomplete needs an overhaul to match the other hooks in Base. It uses different patterns now (like setting a class name, that doesn't happen anywhere else in other hooks).
oliviertassinari
changed the title
Make the demo truly unstyled. Any use of
@mui/materialis a red flag IMHO. I was inspired to work on this (quick-win) while I was looking into https://deploy-preview-5504--material-ui-x.netlify.app/x/react-date-pickers/date-field/#headless-usageBefore
https://mui.com/material-ui/react-autocomplete/#useautocomplete
After
https://deploy-preview-34060--material-ui.netlify.app/material-ui/react-autocomplete/#useautocomplete