Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix missing JSX closing tag in Tooltip docs #34064

Merged
merged 3 commits into from Aug 25, 2022
Merged

[docs] Fix missing JSX closing tag in Tooltip docs #34064

merged 3 commits into from Aug 25, 2022

Conversation

hoangph271
Copy link
Contributor

@hoangph271 hoangph271 commented Aug 25, 2022 •
edited by ZeeshanTamboli

hoangph271 and others added 2 commits August 25, 2022 13:53
@hoangph271
Fix missing close tag
e61974a 
Signed-off-by: Snêu <39024711+hoangph271@users.noreply.github.com>
@ZeeshanTamboli
Merge branch 'master' into zeeshan/fix-missing-close-tag-tooltip-docs
1bd5294
@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation component: tooltip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Aug 25, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title Fix missing close tag [docs] Fix missing close tag in Tooltip docs Aug 25, 2022
@mui-bot
Copy link

mui-bot commented Aug 25, 2022 •
edited

No bundle size changes

Generated by 🚫 dangerJS against 9eb0c6c

@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Fix missing close tag in Tooltip docs [docs] Fix missing jsx close tag in Tooltip docs Aug 25, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Fix missing jsx close tag in Tooltip docs [docs] Fix missing JSX close tag in Tooltip docs Aug 25, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Fix missing JSX close tag in Tooltip docs [docs] Fix missing JSX closing tag in Tooltip docs Aug 25, 2022
ZeeshanTamboli
ZeeshanTamboli approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for your first contribution! Looking forward to more future contributions!

@ZeeshanTamboli ZeeshanTamboli merged commit 2b2cc37 into mui:master Aug 25, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@hoangph271 @ZeeshanTamboli
[docs] Fix missing JSX closing tag in Tooltip docs (mui#34064)
3736688 
* Fix missing close tag

Signed-off-by: Snêu <39024711+hoangph271@users.noreply.github.com>

* yarn prettier

Signed-off-by: Snêu <39024711+hoangph271@users.noreply.github.com>
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
component: tooltip This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hoangph271 @mui-bot @ZeeshanTamboli