Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 not supported by latest published @material-ui/core #34081

Closed
2 tasks done
svenssonaxel opened this issue Aug 26, 2022 · 8 comments
Closed
2 tasks done

React 18 not supported by latest published @material-ui/core #34081

svenssonaxel opened this issue Aug 26, 2022 · 8 comments
Labels
duplicate This issue or pull request already exists package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. v4.x

Comments

@svenssonaxel
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 馃槸

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: abc@1.0.0
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0 || ^17.0.0" from @material-ui/core@4.12.4
npm ERR! node_modules/@material-ui/core
npm ERR!   @material-ui/core@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/user/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/user/.npm/_logs/2022-08-26T13_35_35_881Z-debug-0.log

Expected behavior 馃

npm install succeeds

Steps to reproduce 馃暪

mkdir abc
cd abc
npm init -y
npm i react
npm i @material-ui/core @material-ui/icons

Context 馃敠

No response

Your environment 馃寧

>node -v
v16.16.0
>npm -v
8.11.0
@svenssonaxel svenssonaxel added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 26, 2022
@svenssonaxel
Copy link
Author

It seems like current source supports react 18 in all places but one:

diff --git a/packages/mui-styles/package.json b/packages/mui-styles/package.json
index aa08ce5c48..ec1863b382 100644
--- a/packages/mui-styles/package.json
+++ b/packages/mui-styles/package.json
@@ -39,7 +39,7 @@
   },
   "peerDependencies": {
     "@types/react": "^17.0.0",
-    "react": "^17.0.0"
+    "react": "^17.0.0 || ^18.0.0"
   },
   "peerDependenciesMeta": {
     "@types/react": {

@flaviendelangle

This comment was marked as resolved.

@oliviertassinari
Copy link
Member

Duplicate of #32685

@oliviertassinari oliviertassinari marked this as a duplicate of #32685 Aug 30, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2022
@flaviendelangle

This comment was marked as resolved.

@oliviertassinari

This comment was marked as resolved.

@oliviertassinari

This comment was marked as resolved.

@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 30, 2022
@KaramuddinQaderi

This comment was marked as resolved.

@oliviertassinari oliviertassinari added the package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. label Feb 22, 2023
@VinayBelwal

This comment was marked as duplicate.

@mui mui locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. v4.x
Projects
None yet
Development

No branches or pull requests

6 participants