Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add new components into the related projects page #34123

Merged
merged 9 commits into from Sep 5, 2022

Conversation

viclafouch
Copy link
Contributor

@viclafouch viclafouch commented Aug 29, 2022

Here ! I'm happy to propose 2 useful packages for forms ! One for phone numbers and one for colors 😊

Signed-off-by: Victor de la Fouchardière <victor.dlf@outlook.fr>
Signed-off-by: Victor de la Fouchardière <victor.dlf@outlook.fr>
@mui-bot
Copy link

mui-bot commented Aug 29, 2022

No bundle size changes

Generated by 🚫 dangerJS against 5ae5a25

Signed-off-by: Victor de la Fouchardière <victor.dlf@outlook.fr>
Signed-off-by: Victor de la Fouchardière <victor.dlf@outlook.fr>
@viclafouch viclafouch changed the title [docs] Add mui-color-input into the related projects page [docs] Add mui-color-input and mui-tel-input into the related projects page Aug 30, 2022
@siriwatknp
Copy link
Member

@viclafouch looks great. Can you revert the -pt.md file, it is a translation file that you don't need to update it.

@viclafouch
Copy link
Contributor Author

Hey @siriwatknp ! Done ! (Sorry ^^)

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the hard work!

siriwatknp and others added 2 commits August 30, 2022 18:54
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
Signed-off-by: Victor de la Fouchardière <victor.dlf@outlook.fr>
@viclafouch
Copy link
Contributor Author

viclafouch commented Aug 30, 2022

I've updated the link of TinyColor, it's was an another "TinyColor" :D

Signed-off-by: Victor de la Fouchardière <victor.dlf@outlook.fr>
Signed-off-by: Victor de la Fouchardière <victor.dlf@outlook.fr>
@viclafouch viclafouch changed the title [docs] Add mui-color-input and mui-tel-input into the related projects page [docs] Add mui-color-input, mui-chips-input and mui-tel-input into the related projects page Sep 4, 2022
@siriwatknp siriwatknp merged commit f2fa470 into mui:master Sep 5, 2022
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 16, 2022
oliviertassinari added a commit that referenced this pull request Sep 16, 2022
@oliviertassinari oliviertassinari changed the title [docs] Add mui-color-input, mui-chips-input and mui-tel-input into the related projects page [docs] Add new components into the related projects page Sep 16, 2022
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viclafouch Thanks for these new components 👍 . We normally don't like any new project until they reach > 100 GitHub stars to make sure that they fill a large enough gap in the market, but it's always interesting to try different approaches.

### Color picker

- [mui-color-input](https://viclafouch.github.io/mui-color-input): A color input designed for the React library MUI built with [TinyColor](https://tinycolor.vercel.app/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links are 301

Suggested change
- [mui-color-input](https://viclafouch.github.io/mui-color-input): A color input designed for the React library MUI built with [TinyColor](https://tinycolor.vercel.app/).
- [mui-color-input](https://viclafouch.github.io/mui-color-input/): A color input designed for the React library MUI built with [TinyColor](https://tinycolor.vercel.app/).

I have fixed it in 8d138ab

Comment on lines +31 to +34
### Chips

- [mui-chips-input](https://viclafouch.github.io/mui-chips-input): A chips input designed for the React library MUI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the community need this chip component? I mean, it seems to duplicate with https://mui.com/material-ui/react-autocomplete/#multiple-values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @oliviertassinari ! Thanks for your question, it's a little bit different because it's not an autocomplete. Here, it's just a simple input where you have less logic...

@viclafouch
Copy link
Contributor Author

viclafouch commented Sep 16, 2022

@oliviertassinari

@viclafouch Thanks for these new components 👍 . We normally don't like any new project until they reach > 100 GitHub stars to make sure that they fill a large enough gap in the market, but it's always interesting to try different approaches.

Got it ! Sorry I didn't know :/

daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants