Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structured / semantic markup for steps and steppers #34138

Merged
merged 5 commits into from Sep 5, 2022

Conversation

paulschreiber
Copy link
Contributor

@paulschreiber paulschreiber commented Aug 30, 2022

Use structured / semantic markup for steppers and steps. Improves experience for screen reader users.

  • Add component overriding to the Stepper component.
  • Add component overriding to the Step component.
  • Have Stepper use ol by default. (consider in v6)
  • Have Step use li by default. (consider in v6)

Fixes #34137.

@mui-bot
Copy link

mui-bot commented Aug 30, 2022

Details of bundle changes

Generated by 🚫 dangerJS against fb4d42c

@paulschreiber
Copy link
Contributor Author

@siriwatknp here is a similar change to #33994.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution.

@siriwatknp
Copy link
Member

I am merging this even though argos is not responded. The change does not change the visual appearance of the component.

@siriwatknp siriwatknp merged commit c532d19 into mui:master Sep 5, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@zannager zannager added the component: stepper This is the name of the generic UI component, not the React module! label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper and Step use unstructured markup
4 participants