[blog] The Date Pickers gets a stable v5 release #34152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
requested review from
flaviendelangle,
joserodolfofreitas,
LukasTy and
samuelsycamore
LukasTy
reviewed
Aug 31, 2022
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
alexfauquette
commented
Sep 1, 2022
Co-authored-by: Lukas <llukas.tyla@gmail.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
| @@ -0,0 +1,100 @@ | |||
| --- | |||
| title: 'The Date pickers gets a stable v5 release' | |||
There was a problem hiding this comment.
Suggested change
| title: 'The Date pickers gets a stable v5 release' | |
| title: 'The Date Pickers gets a stable v5 release' |
@samuelsycamore, I'm a bit confused about the case on this one, since "Date Pickers" is not really a component but more like a reference to package(?).
There was a problem hiding this comment.
@joserodolfofreitas That's the last element to modify or not. Otherswise it's good for publiction
I think it would be great. Can we use the same card generator we use for MUI X releases? |
Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
joserodolfofreitas
approved these changes
Sep 15, 2022
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
oliviertassinari
changed the title
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
|
Can we update the card to fix the grammar? We can just use the same wording as the updated title. |
|
@samuelsycamore Is this one ok?
|
|
Looks great @alexfauquette ! |
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: Lukas <llukas.tyla@gmail.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joserodolfofreitas I've added a section to highlight the adoption rate of the new version, since it can be a social argument to encourage migration
Will we need a card for this blog post?
preview: https://deploy-preview-34152--material-ui.netlify.app/blog/date-pickers-stable-v5/