[blog] Fix social cards #34160
Merged
[blog] Fix social cards #34160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelsycamore
approved these changes
Aug 31, 2022
|
@oliviertassinari Thanks! I'm about to fix this issue 🤣 |
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this in my Twitter thread:
#33926. So I had a look at how I could fix the root problem. Turns out it's because of the instructions in https://www.notion.so/mui-org/Blog-247ec2bff5fa46e799ef06a693c94917#8d7abbf2117b4f28a671adc8bff4b13b are wrong. I have fixed the content in Notion to not lead toward card.jpg but card.png.
material-ui/docs/src/modules/components/TopLayoutBlog.js
Line 220 in 660b9da
You might also wonder, why png and not jpg? Because see the same image exported in the two different formats, after compression:
a png is x3.0 smaller.