Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Standardize all MUI Core "Installation" pages #34168

Merged
merged 11 commits into from Sep 26, 2022

Conversation

samuelsycamore
Copy link
Member

@samuelsycamore samuelsycamore commented Sep 1, 2022

This PR aims to bring consistent formatting, structure, and language to all of the Installation pages under the MUI Core umbrella. Originally meant to be a part of #33998 but might as well update all of these pages together in one PR.

I've also extracted the "Design resources" section from the Material UI Installation page to its own standalone page, because it seemed kind of out of place and buried there. I'm open to suggestions for improving it.

Previews:

@samuelsycamore samuelsycamore added the docs Improvements or additions to the documentation label Sep 1, 2022
@mui-bot
Copy link

mui-bot commented Sep 1, 2022

No bundle size changes

Generated by 🚫 dangerJS against 78e12e3

@samuelsycamore samuelsycamore marked this pull request as ready for review September 2, 2022 01:03
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 15, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 19, 2022
@samuelsycamore samuelsycamore requested review from michaldudak and danilo-leal and removed request for siriwatknp September 20, 2022 14:55
@samuelsycamore
Copy link
Member Author

I've removed the "default" headers from the pages where there is only one way to install.

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great to me! By the way, @siriwatknp, realized we're not talking anything about typeface import for Joy, should we? Just pointing it out as there's a good portion there on Material UI talking about importing Roboto.

@siriwatknp
Copy link
Member

Looking great to me! By the way, @siriwatknp, realized we're not talking anything about typeface import for Joy, should we? Just pointing it out as there's a good portion there on Material UI talking about importing Roboto.

Good point. I think it can be a separate PR to think about so it does not block this PR.

@siriwatknp siriwatknp merged commit 0bf50cb into mui:master Sep 26, 2022
alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Oct 14, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@samuelsycamore samuelsycamore deleted the installation-pages branch April 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants