Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix crash due to using wrong variable #34171

Merged
merged 1 commit into from Sep 2, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Sep 2, 2022

#33937 and #34087 did not sync.

The variable (asPathWithoutLang) in #33937 did not update in #34087, so the docs crashes.

@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Sep 2, 2022
@mui-bot
Copy link

mui-bot commented Sep 2, 2022

No bundle size changes

Generated by 🚫 dangerJS against 5959b4a

@siriwatknp
Copy link
Member Author

I am merging this PR even though test_regressions failed (could not upload to argos). This PR does not impact the packages, so it is not related to argos.

@ZeeshanTamboli
Copy link
Member

I am facing the same issue of asPathWithoutLang in #34166, nice to see it fixed 👍 but I am also facing the same issue of test_regressions (could not upload to Argos) in my PR.

@siriwatknp siriwatknp merged commit fe5d0ad into mui:master Sep 2, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants